[PhpUnitBridge] respect skipped and incomplete tests #21121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 1, 2017
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 3.2 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
xabbuh
force-pushed
the
phpunit-skipped-incomplete-tests
branch
from
fad9f0a
to
0c06093
Compare
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 2, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [PhpUnitBridge] respect skipped and incomplete tests | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 0c06093 respect skipped and incomplete tests
|
what happens when it is already in errored state ? |
fabpot
added a commit
that referenced
this pull request
Jan 2, 2017
…oo (xabbuh) This PR was merged into the 3.2 branch. Discussion ---------- [PhpUnitBridge] skip tests with failure and error states too | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I was actually wrong by not excluding failures and errors to in #21121. Commits ------- f3bb206 skip tests with failure and error states too
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.