Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CacheDataCollector and CacheCollectorPass not compatible with TraceableCache #23937

Closed
hcomnetworkers opened this issue Aug 20, 2017 · 6 comments
Labels
Cache Feature Help wanted Issues and PRs which are looking for volunteers to complete them.

Comments

@hcomnetworkers
Copy link

hcomnetworkers commented Aug 20, 2017

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? yes, PSR-16
Symfony version >=3.3

CacheDataCollector and respective CacheCollectorPass do not work with the TraceableCache.

Both TraceableCache and TraceableAdapter should implement a common interface for the getCalls-method and the events TraceableCacheEvent and TraceableAdapterEvent could be the same class and put in a new file.

@nicolas-grekas
Copy link
Member

ping @Nyholm if you want to look at it

@Nyholm
Copy link
Member

Nyholm commented Aug 25, 2017

Sure, I will have a look tonight or over the weekend

@Simperfit
Copy link
Contributor

@Nyholm do you have some time to take this, or do you want me to do it ?

@Nyholm
Copy link
Member

Nyholm commented Feb 26, 2018

Oh, as you can see. I've totally forgotten about this. Please Hamza, feel free to have a look.

@nicolas-grekas nicolas-grekas added the Help wanted Issues and PRs which are looking for volunteers to complete them. label Feb 25, 2019
@jeroennoten
Copy link
Contributor

@nicolas-grekas is this issue still relevant? It seems that the class TraceableCache was deprecated in Symfony 4.3:

The "TraceableCache" class is deprecated since Symfony 4.3, use "TraceableAdapter" and type-hint for "CacheInterface" instead.

And in the 5.x branch, the TraceableCache class is gone.

@nicolas-grekas
Copy link
Member

Correct, thanks, let's close. If someone has the issue on 4.4 and wants to fix it, PR welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cache Feature Help wanted Issues and PRs which are looking for volunteers to complete them.
Projects
None yet
Development

No branches or pull requests

6 participants