Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AnnotationCacheWarmer] add RedirectController to annotation cache #33781

Merged

Conversation

jenschude
Copy link
Contributor

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #29357
License MIT

This prevents to exclude the RedirectController from the warmed annotation cache which would lead to warnings when trying to use the warmed cache on read only file systems

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Oct 2, 2019
This prevents to exclude the RedirectController from the warmed annotation cache which would lead to warnings when trying to use the warmed cache on read only file systems

See symfony#29357
@nicolas-grekas nicolas-grekas changed the base branch from 4.3 to 3.4 October 2, 2019 09:29
@nicolas-grekas nicolas-grekas force-pushed the fine-tune-annotation-cache-warming branch from 477b3cc to 6b6c246 Compare October 2, 2019 09:29
@nicolas-grekas
Copy link
Member

Thank you @jenschude.

nicolas-grekas added a commit that referenced this pull request Oct 2, 2019
…on cache (jenschude)

This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes #33781).

Discussion
----------

[AnnotationCacheWarmer] add RedirectController to annotation cache

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #29357
| License       | MIT

This prevents to exclude the RedirectController from the warmed annotation cache which would lead to warnings when trying to use the warmed cache on read only file systems

Commits
-------

6b6c246 [AnnotationCacheWarmer] add RedirectController to annotation cache
@nicolas-grekas nicolas-grekas merged commit 6b6c246 into symfony:3.4 Oct 2, 2019
@jenschude jenschude deleted the fine-tune-annotation-cache-warming branch October 2, 2019 09:31
This was referenced Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants