Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifier][RFC] Chatters and texters should not be transports #34545

Closed
magnusnordlander opened this issue Nov 23, 2019 · 2 comments
Closed
Labels

Comments

@magnusnordlander
Copy link
Contributor

I was trying to understand the notifier component in order to write documentation for it, and I'm confused by Chatters and Texters.

I don't understand why Chatters and Texters are transports? Is there a use case where you'd want to do something like the following?

<?php
$notifier = new Notifier([
    new SmsChannel(new Chatter(new TwilioTransport('foo', 'bar', 'baz')))
]);

I'd be happy to work on a PR for this, but I would like some feedback first.

#SymfonyHackday

@wouterj
Copy link
Member

wouterj commented Feb 2, 2020

I think the main idea is not in initialization, but in usage. You can write a class that is agnostic on how the notification is actually sent. It would be happy to accept a chatter, a texter or the high-level notifier object. This makes it somewhat easier to switch between these.

@fabpot
Copy link
Member

fabpot commented May 3, 2020

The idea is that you can use Chatters and/or Texters without Notifier.

@fabpot fabpot closed this as completed May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants