[Asset] PathPackage combined with JsonManifestVersionStrategy not sitable with laravel-mix manifest

[glensc]

Description

Laravel Mix provides a fluent API for defining Webpack build steps for your Laravel application using several common CSS and JavaScript pre-processors.

The mix manifest is created with a leading slash:

{
    "/dist/main.js": "/dist/main.js?id=ecfe06d840525bff34b2",
    "/dist/main.css": "/dist/main.css?id=5b13608ecbc9f614ba25"
}

This file is compatible with JsonManifestVersionStrategy,
however PathPackage to prepend path expects input to be without leading slash.

Example

• Asset.php

// I expect to get as result: /example/dist/main.js?id=ecfe06d840525bff34b2

$manifestPath = 'mix-manifest.json';
$relativeUrl = '/example';
$versionStrategy = new JsonManifestVersionStrategy($manifestPath);
$package = new PathPackage($relativeUrl, $versionStrategy);

// returns /dist/main.js?id=ecfe06d840525bff34b2 because leading slash
var_dump($package->getUrl("/dist/main.js"));

// returns "/example/dist/main.js" because no match in manifest
var_dump($package->getUrl("dist/main.js"));

[glensc]

Altho I'd like to see a solution from Symfony/Asset side, I've updated on the Mix side to strip prefix from items.

Origin: glensc/eventum@6f38e33

const collect = require('collect.js');

/**
 * Update manifest to remove leading slash of key => value pairs
 * @author Elan Ruusamäe <glen@pld-linux.org>
 * @see https://github.com/symfony/symfony/issues/36234
 */
mix.extend('updateManifestPathsRelative', (config) => {
    config.plugins.push(new class {
        apply(compiler) {
            compiler.plugin('done', () => {
                const manifest = {};
                collect(Mix.manifest.get()).each((value, key) => {
                    key = this.normalizePath(key);
                    value = this.normalizePath(value);
                    manifest[key] = value;
                });
                Mix.manifest.manifest = manifest;
                Mix.manifest.refresh();
            });
        }

        /**
         * @param {string} filePath
         */
        normalizePath(filePath) {
            if (filePath.startsWith('/')) {
                filePath = filePath.substring(1);
            }

            return filePath;
        }
    })
});

mix.updateManifestPathsRelative();

[carsonbot]

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

[glensc]

[carsonbot]

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

[glensc]

@carsonbot I don't see anyone from Symfony side triaged this.

[GromNaN]

The described behavior was intentionally implemented (and fixed) by #22528. The base path is not prepend to asset paths that start with a /.

[carsonbot]

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

[glensc]

I don't think any progress have been made here.

[carsonbot]

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

[glensc]

No.

[carsonbot]

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

[carsonbot]

Could I get a reply or should I close this?

[carsonbot]

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!