Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Translation][Loco] Consider sending If-Modified-Since or If-None-Match header when pulling translations #44414

Closed
Kocal opened this issue Dec 2, 2021 · 4 comments · Fixed by #44484
Closed

[Translation][Loco] Consider sending If-Modified-Since or If-None-Match header when pulling translations #44414

Kocal opened this issue Dec 2, 2021 · 4 comments · Fixed by #44484
Labels
Feature Translation

Comments

@Kocal
Copy link
Contributor

Kocal commented Dec 2, 2021 •
edited

Description

In their documentation, Loco recommends to send header If-Modified-Since (with the previous value of Last-Modified response header) or header If-None-Match (with the previous value of ETag response header), if you need to download changes very regularly (which can be the case in local or CI).

By implementing this, we can reduce the work load on their side and maybe on our side too.

WDYT?

Example

No response
@Kocal Kocal changed the title [Feature][Loco] Consider sending If-Modified-Since or If-None-Match header when pulling translations [Feature][Translation][Loco] Consider sending If-Modified-Since or If-None-Match header when pulling translations Dec 2, 2021
@Kocal Kocal changed the title [Feature][Translation][Loco] Consider sending If-Modified-Since or If-None-Match header when pulling translations [Translation][Loco] Consider sending If-Modified-Since or If-None-Match header when pulling translations Dec 2, 2021
@fabpot
Copy link
Member

fabpot commented Dec 2, 2021

Looks like a good idea to me. Up for a PR?

@welcoMattic
Copy link
Member

Looks good to me too @Kocal, go ahead for a PR

@Kocal
Copy link
Contributor Author

Kocal commented Dec 2, 2021 •
edited

I will try to open a PR ASAP. Should Last-Modified be stored inside the .xlf file?

Should I target branch 5.3 or 6.1? To me that's a new internal feature that won't be visible to the end user, so I'm more in favor of 5.3.

@fabpot
Copy link
Member

fabpot commented Dec 2, 2021

Not a bug, do 6.1.

@Kocal Kocal mentioned this issue Dec 6, 2021
Merged
@fabpot fabpot closed this as completed in 74b8d16 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Translation] [Loco] Send If-Modified-Since header when possible
5 participants
@fabpot @welcoMattic @xabbuh @Kocal @carsonbot