We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LockFactory returns SharedLocksInterface's
symfony/src/Symfony/Component/Lock/LockFactory.php
Lines 44 to 47 in 98e0fa4
Lines 56 to 62 in 98e0fa4
symfony/src/Symfony/Component/Lock/Lock.php
Line 28 in 98e0fa4
Should we update the return types?
Also acquireRead() may forward to acquire()
acquireRead()
acquire()
Lines 136 to 144 in 98e0fa4
which raises questions about this contract in the first place ... :) perhaps an @method on LockInterface is possible still?
@method
LockInterface
No response
The text was updated successfully, but these errors were encountered:
Addiotionally having NoLock implements SharedLockInterface, provided if $factory->test === true would be nice, for testing purposes
NoLock implements SharedLockInterface
$factory->test === true
Never mind, i'll use InMemoryStore 🤷
Sorry, something went wrong.
e7142a6
Successfully merging a pull request may close this issue.
Description
LockFactory returns SharedLocksInterface's
symfony/src/Symfony/Component/Lock/LockFactory.php
Lines 44 to 47 in 98e0fa4
symfony/src/Symfony/Component/Lock/LockFactory.php
Lines 56 to 62 in 98e0fa4
symfony/src/Symfony/Component/Lock/Lock.php
Line 28 in 98e0fa4
Should we update the return types?
Also
acquireRead()
may forward toacquire()
symfony/src/Symfony/Component/Lock/Lock.php
Lines 136 to 144 in 98e0fa4
which raises questions about this contract in the first place ... :) perhaps an
@method
onLockInterface
is possible still?Example
No response
The text was updated successfully, but these errors were encountered: