[PropertyAccess] Readonly properties must have no PropertyWriteInfo #48108
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
CasvanDongen
changed the title
|
Hey! I think @Tomanhez has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
@dunglas or @nicolas-grekas is it possible to review this PR? |
carsonbot
changed the title
|
@dunglas @nicolas-grekas any chance to see this merged? 🙏 |
nicolas-grekas
changed the title
| @@ -397,8 +397,11 @@ public function getWriteInfo(string $class, string $property, array $context = [ | |||
|
|
|||
| if ($reflClass->hasProperty($property) && ($reflClass->getProperty($property)->getModifiers() & $this->propertyReflectionFlags)) { | |||
| $reflProperty = $reflClass->getProperty($property); | |||
| if (\PHP_VERSION_ID < 80100 || (false === $reflProperty->isReadOnly() && false === $reflProperty->isPromoted())) { | |||
There was a problem hiding this comment.
If I remove the part about $reflProperty->isPromoted() (which I just did and pushed), tests still pass. This makes me wonder what how this relates to property promotion? Isn't this only about readonly?
There was a problem hiding this comment.
That's my mistake. I've missed the part that readonly properties in the constructor are automatically promoted. The change above indeed is correct.
nicolas-grekas
force-pushed
the
property-accessor-php-81-writemutator-readonly-promoted-properties
branch
from
d0d1096
to
813b950
Compare
src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
property-accessor-php-81-writemutator-readonly-promoted-properties
branch
from
813b950
to
2aa6c7d
Compare
|
Thank you @CasvanDongen. |
The reported WriteInfo of readonly promoted properties is incorrectly returned as a writeable property when constructor extraction is disabled. This PR fixes that by correctly returning
PropertyWriteInfo::TYPE_NONEwhenenable_constructor_extractionisfalse.Obviously, this fix only applies to PHP8.1 or higher.