Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Fix computing column width containing multibyte chars #48886

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

cay89
Copy link
Contributor

@cay89 cay89 commented Jan 5, 2023

Use mb_str_split instead of str_split because it works badly with multibyte chars on auto width adjustment.

Q A
Branch? 5.4 and above
Bug fix? yes

Console output with str_split:

image

Console output with mb_str_split:

image

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "5.4" but it seems your PR description refers to branch "5.4 and above".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

I think @yoannrenard has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@xabbuh xabbuh added the Console label Jan 6, 2023
@carsonbot carsonbot changed the title Update Table.php [Console] Update Table.php Jan 6, 2023
@xabbuh
Copy link
Member

xabbuh commented Jan 6, 2023

Can you add a test case to avoid regressions?

@cay89
Copy link
Contributor Author

cay89 commented Jan 12, 2023

Can you add a test case to avoid regressions?

I don't have much time, but I'll try to add a test for it.

@nicolas-grekas nicolas-grekas changed the title [Console] Update Table.php [Console] Fix computing column width containing multibyte chars Apr 18, 2023
@nicolas-grekas
Copy link
Member

Thank you @cay89.

@nicolas-grekas nicolas-grekas merged commit 2e66dcc into symfony:5.4 Apr 18, 2023
9 checks passed
This was referenced Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants