Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] trim(): Argument #1 () must be of type string, bool given #50143

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Apr 24, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

If you run a Symfony Console application in Git Bash, ANSICON is not set out of the box and results in this (suppressed) error:

trim(): Argument ($string) must be of type string, bool given

AFAICT, this method is only called from Application::run() and errors are suppressed. So users will never actually see that error. Still, it could have side effects and breaks downstream projects: box-project/box#990

@carsonbot carsonbot changed the title trim(): Argument #1 () must be of type string, bool given [Console] trim(): Argument #1 () must be of type string, bool given Apr 24, 2023
@chalasr
Copy link
Member

chalasr commented Apr 25, 2023

Thank you @danepowell.

@chalasr chalasr merged commit 176d1de into symfony:5.4 Apr 25, 2023
9 checks passed
This was referenced Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants