Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebProfilerBundle] Remove legacy filters remnants #50214

Merged
merged 1 commit into from May 5, 2023
Merged

[WebProfilerBundle] Remove legacy filters remnants #50214

merged 1 commit into from May 5, 2023

Conversation

MatTheCat
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

#42195 introduced new filters for the WebProfilerBundle but it still contains some remnants, for example in the translation panel:

Uncaught TypeError: Sfjs.createFilters is not a function

This PR removes them all.

@carsonbot carsonbot added this to the 5.4 milestone May 2, 2023
javiereguiluz
javiereguiluz approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks Mathieu!

The ideal solution would be to recreate these filters in the new system instead of just removing the old filters which no longer work.

I've added this to my TODO list to see if I can do it for Symfony 6.4/7.0.

Thanks!

@nicolas-grekas
Copy link
Member

Thank you @MatTheCat.

@nicolas-grekas nicolas-grekas merged commit d3092c7 into symfony:5.4 May 5, 2023
9 of 11 checks passed
@MatTheCat MatTheCat deleted the clean-filters-remnants branch May 5, 2023 15:51
@MatTheCat
Copy link
Contributor Author

@javiereguiluz yes having the new filters everywhere (on the exception page as well; see #50213) would be nice!

@nicolas-grekas
Copy link
Member

I merged this up to 6.3

@fabpot fabpot mentioned this pull request May 7, 2023
Merged
This was referenced May 27, 2023
Merged
Merged
@renovate renovate bot mentioned this pull request Jul 10, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Dec 27, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MatTheCat @nicolas-grekas @javiereguiluz @carsonbot