[FrameworkBundle] Generate caches consistently on successive run of cache:clear command
#50253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cache:clear` command
nicolas-grekas
requested review from
lyrixx,
yceruto,
wouterj,
chalasr,
dunglas,
OskarStark and
xabbuh
as code owners
nicolas-grekas
force-pushed
the
ticket_46324
branch
from
81e1db5
to
dcbdca6
Compare
|
Thank you @Okhoshi. |
|
Thank you! |
Okhoshi
added a commit
to Okhoshi/symfony
that referenced
this pull request
May 14, 2023
…uccessive run of `cache:clear` command
This was referenced May 22, 2023
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Kernel is configured to use different directories for
build_dirandcache_dir, successive runs of thecache:clearproduce different outputs. See #46324 for the reproduction steps and the differences observed.This is due to the fact that if the cached kernel needs to be regenerated when invoking
cache:clearcommand, the cache warmers are run in the same directory where the kernel was regenerated ($warmupDir, which will become thebuild_dir). When the cache is fresh, only cache warmers are run, and incache_dirthis time.