Hide definitions bearing the container.excluded tag

[Myks92]

Q	A
Branch?	6.2
Bug fix?	yes
New feature?	no
	Depreciation?
Tickets	Fix #50417
License	MIT
Doc PR	-

Normally I test whether the exclusion rules from the service container of my bundles work correctly by just using the debug:container command and looking whether my excluded services occur in the last.
However, due to the latest changes in #46279 all folders and subfulders (excluded or not) are always in this list.

You need to open the definition to see if it was excluded:

For example, Command, Query, Entity are folders, but they are specified as services in the container.

This PR fixes this problem to ignore definitions bearing the container.excluded tag if those are to be hidden for Descriptors: JsonDescriptor, MarkdownDescriptor, TextDescriptor and XmlDescriptor.

After fixes problem:

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[nicolas-grekas]

Can you please check if this issue happens on 6.3? We might have fixed this as an improvement already.

[MatTheCat]

@nicolas-grekas I can confirm this still happens with Symfony 6.3.0 RC2

[MatTheCat]

LGTM, maybe just make line breaks consistent 👍

[chalasr]

Looks good, thank you for contributing.
Can you have a look ContainerDebugCommandTest and see if you can add a test to prevent future regressions?

[Myks92]

@chalasr, I added tests for Descriptor and ContainerDebugCommand. Is that what you need?

[chalasr]

Thank you @Myks92.