[Validator] Accept Stringable in ExecutionContext::build/addViolation()

[alexandre-daubois]

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix symfony/symfony-docs#19704
License	MIT

ConstraintViolationBuilder accepts any stringable. We mentioned this in the doc but it doesn't work as explained in the issue. I think buildViolation() could accept stringable, also given that ExecutionContextInterface defines the type as string|Stringable in the PHPDoc.

Same for addViolation().

[nicolas-grekas]

Just to be sure: this matters only when strict types are enabled, right? Looking at the @param in the interface, I'd say we might have forgotten to change the type there in 7.0. Let's do it on 7.0 as a bugfix?

[alexandre-daubois]

Indeed! It works as-is when strict types are disabled. I guess we have to wait for the next major to update the interface, even if it's a bug?

[nicolas-grekas]

Ah no sorry, the change was fine for 6.4.
For 7.0, that'd be on the interface.
We might want to check other @param in case we forgot to update a few others. Not sure how.

[alexandre-daubois]

Got back to 6.4. 👍

I think this is something that may be doable with some custom PHPStan rule? I didn't play with this yet, that's an interesting case. I'll try something when I have some time.

[nicolas-grekas]

Note that strict types are just a bad idea :)

[fabpot]

Thank you @alexandre-daubois.