[Finder] adds a way to ignore AccessDeniedException

[jfsimon]

This PR adds a Finder::ignoreUnreadableDirs() method which tells Finder to ignore unreadable directories instead of throwing an AccessDeniedException.

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#6981

[jfsimon]

@vicb are you okay with the ignoreUnreadableDirs name?

[vicb]

(Boolean) $ignore

[jfsimon]

changed

[vicb]

Does not sound 100% right to me but I can't find anything better. May be a native speaker could help here to know if this is good or come with a better name ?

[lazyhammer]

adds a way to ignore AccessDeniedException

So maybe Inaccessible?

[staabm]

Maybe omitInaccesible? ignorePermissions?

[kingcrunch]

Or the other way round, for example accessibleOnly, or readableOnly

[jfsimon]

@vicb do you have an idea regarding to above suggestions?

[vicb]

I let you pick the best. I think there must be a verb in the name, ie setAccessibleOnly.

I have one question that is somehow related to this PR: What happens with unreadable files ? Let's say that you are looking for a file which contains "<?php" but some of the file are not readable by the process which runs the Finder, what would happen, Would the AccessDeniedException been thrown ?

If this is not the case yet, the code should be updated (both native & php drivers).

There should also be a way to ignore those exceptions, ie ->ignoreUnreadable(Finder::FILE | Finder::DIRECTORY)

[jfsimon]

Go for setAccessibleOnly.

In the case of an unreadable file content lookup, the native adapter throws an AccessDeniedException (as this exception is thrown anytime stderr returns something), but in the case of the PHP adapter the file is just not matched if not readable. Changing this will be a BC break, but is required as the current behavior it's not consistent.

[vicb]

the PHP adapter the file is just not matched if not readable

why ?

Edit: ok, found why

[jfsimon]

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Finder/Iterator/FilecontentFilterIterator.php#L35