[Process] Check if the pipe array is empty before calling stream_select() #9367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pipe array is either set to null or is empty occasionally when readStreams() is called. This generates a warning frequently which can cause issues for custom shutdown functions. Adding a check to see if the pipe array is empty should be functionally equivalent without having to generate the error. Fixes: symfony#9280
|
|
||
| class ProcessDoesNotThrowWarningTest extends \PHPUnit_Framework_TestCase | ||
| { | ||
| public function testThatProcessDoesNotThrowWarningDuringRun(){ |
There was a problem hiding this comment.
This tests should be in the ProcessTest class
|
As |
| @@ -251,6 +251,10 @@ private function readFileHandles($close = false) | |||
| */ | |||
| private function readStreams($blocking, $close = false) | |||
| { | |||
| if(empty($this->pipes)){ | |||
| return []; | |||
There was a problem hiding this comment.
You should use PHP 5.3 compatible notation as Symfony is compatible from 5.3.3.
|
how about that issue? When it can be merged to 2.3 and released? |
|
As mentioned by @romainneutron, this PR must be done on 2.2. |
fabpot
added a commit
that referenced
this pull request
Nov 15, 2013
…tream_select() (jfposton) This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9367). Discussion ---------- [Process] Check if the pipe array is empty before calling stream_select() | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9280 | License | MIT | Doc PR | ProcessPipes generates a warning frequently which can cause issues for custom shutdown functions. Adding a check to see if the pipe array is empty should be functionally equivalent without having to generate the error. Fixes: #9280 Commits ------- 12f95e2 [Process] Check if the pipe array is empty before calling stream_select()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProcessPipes generates a warning frequently which can cause issues for custom shutdown functions. Adding a check to see if the pipe array is empty should be functionally equivalent without having to generate the error.
Fixes: #9280