Adjust attributes names and allow choosing a custom HTML tag

symfony · Sep 26, 2023 · 7f62a42 · 7f62a42
1 parent fd97359
commit 7f62a42
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/src/LiveComponent/src/EventListener/AddLiveAttributesSubscriber.php b/src/LiveComponent/src/EventListener/AddLiveAttributesSubscriber.php
@@ -35,6 +35,10 @@
  */
 final class AddLiveAttributesSubscriber implements EventSubscriberInterface, ServiceSubscriberInterface
 {
+    private const DEFAULT_LOADING_TAG = 'div';
+
+    private const DEFAULT_LOADING_TEMPLATE = null;
+
     public function __construct(
         private ComponentStack $componentStack,
         private TemplateMap $templateMap,
@@ -80,9 +84,9 @@ public function onPreRender(PreRenderEvent $event): void
             if ($isDeferred) {
                 $event->setTemplate('@LiveComponent/deferred.html.twig');
 
-                if ($loadingTemplate) {
-                    $variables['loadingTemplate'] = $loadingTemplate;
-                }
+                $variables['loadingTag'] = $originalAttributes['loading-tag'] ?? self::DEFAULT_LOADING_TAG;
+                $variables['loadingTemplate'] = $originalAttributes['loading-template'] ?? self::DEFAULT_LOADING_TEMPLATE;
+                $attributes = $attributes->without('defer', 'loading-element', 'loading-template');
             }
         }
 

diff --git a/src/LiveComponent/templates/deferred.html.twig b/src/LiveComponent/templates/deferred.html.twig
@@ -1,5 +1,7 @@
-<div {{ attributes }} data-action="live:connect->live#$render">
-    {% if loadingTemplate is defined and loadingTemplate != null %}
-        {{ include(loadingTemplate) }}
-    {% endif %}
-</div>
+<{{ loadingTag }} {{ attributes }} data-action="live:connect->live#$render">
+    {% block loadingContent %}
+        {% if loadingTemplate != null %}
+            {{ include(loadingTemplate) }}
+        {% endif %}
+    {% endblock %}
+</{{ loadingTag }}>