Skip to content

Commit

Permalink
bug #1268 Remove "type": "module" from all package.json files (smnandre)
Browse files Browse the repository at this point in the history
This PR was squashed before being merged into the 2.x branch.

Discussion
----------

Remove "type": "module" from all package.json files

Since #1264, another person could not build its assets with Encore and a babel plugin.

So for now we decided to revert the "type: module" declaration.

### Revert the "type: module"

Remove this "type" line from all package.json files and revert replacing "main:" with "module:"

Before
```json
   "type": "module",
   "module": "dist/foo.js",
```

After
```json
   "main": "dist/foo.js",
```

### Fix Svelte ESM bug with vite/vitest

```
We recommend converting your config to ESM by either:

    adding "type": "module" to the nearest package.json
    renaming vite.config.js/vite.config.ts to vite.config.mjs/vite.config.mts
```
(https://vitejs.dev/guide/troubleshooting.html#config)

So i used the second one.... and it seems to work

Commits
-------

919ade7 Remove "type": "module" from all package.json files
  • Loading branch information
weaverryan committed Nov 11, 2023
2 parents d4e3f0a + 919ade7 commit a7fdbf8
Show file tree
Hide file tree
Showing 33 changed files with 80 additions and 31 deletions.
4 changes: 4 additions & 0 deletions src/Autocomplete/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Add new BaseEntityAutocompleteType
Expand Down
3 changes: 1 addition & 2 deletions src/Autocomplete/assets/package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "@symfony/ux-autocomplete",
"description": "JavaScript-powered autocompletion functionality for forms.",
"module": "dist/controller.js",
"type": "module",
"main": "dist/controller.js",
"types": "dist/controller.d.ts",
"version": "1.0.0",
"license": "MIT",
Expand Down
4 changes: 4 additions & 0 deletions src/Chartjs/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Add Symfony 7 support.
Expand Down
2 changes: 1 addition & 1 deletion src/Chartjs/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Chart.js integration for Symfony",
"license": "MIT",
"version": "1.1.0",
"module": "dist/controller.js",
"main": "dist/controller.js",
"types": "dist/controller.d.ts",
"symfony": {
"controllers": {
Expand Down
4 changes: 4 additions & 0 deletions src/Cropperjs/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Add Symfony 7 support.
Expand Down
3 changes: 1 addition & 2 deletions src/Cropperjs/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"description": "Cropper.js integration for Symfony",
"license": "MIT",
"version": "1.1.0",
"module": "dist/controller.js",
"type": "module",
"main": "dist/controller.js",
"types": "dist/controller.d.ts",
"config": {
"css_source": "src/style.css"
Expand Down
4 changes: 4 additions & 0 deletions src/Dropzone/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Add Symfony 7 support.
Expand Down
3 changes: 1 addition & 2 deletions src/Dropzone/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"description": "File input dropzones for Symfony Forms",
"license": "MIT",
"version": "1.1.0",
"module": "dist/controller.js",
"type": "module",
"main": "dist/controller.js",
"types": "dist/controller.d.ts",
"config": {
"css_source": "src/style.css"
Expand Down
4 changes: 4 additions & 0 deletions src/LazyImage/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Add Symfony 7 support.
Expand Down
3 changes: 1 addition & 2 deletions src/LazyImage/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"description": "Lazy image loader and utilities for Symfony",
"license": "MIT",
"version": "1.1.0",
"module": "dist/controller.js",
"type": "module",
"main": "dist/controller.js",
"types": "dist/controller.d.ts",
"symfony": {
"controllers": {
Expand Down
4 changes: 4 additions & 0 deletions src/LiveComponent/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Add deferred/lazy rendering of Live Components.
Expand Down
3 changes: 1 addition & 2 deletions src/LiveComponent/assets/package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "@symfony/ux-live-component",
"description": "Live Component: bring server-side re-rendering & model binding to any element.",
"module": "dist/live_controller.js",
"type": "module",
"main": "dist/live_controller.js",
"types": "dist/live_controller.d.ts",
"version": "1.0.0",
"config": {
Expand Down
4 changes: 4 additions & 0 deletions src/Notify/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Add Symfony 7 support.
Expand Down
3 changes: 1 addition & 2 deletions src/Notify/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"description": "Native notification integration for Symfony using Mercure",
"license": "MIT",
"version": "1.0.0",
"module": "dist/controller.js",
"type": "module",
"main": "dist/controller.js",
"types": "dist/controller.d.ts",
"symfony": {
"controllers": {
Expand Down
4 changes: 4 additions & 0 deletions src/React/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Add Symfony 7 support.
Expand Down
3 changes: 1 addition & 2 deletions src/React/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"description": "Integration of React in Symfony",
"license": "MIT",
"version": "1.0.0",
"module": "dist/register_controller.js",
"type": "module",
"main": "dist/register_controller.js",
"types": "dist/register_controller.d.ts",
"symfony": {
"controllers": {
Expand Down
4 changes: 4 additions & 0 deletions src/StimulusBundle/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Normalize parameters names given to twig helper 'stimulus_action()'.
Expand Down
3 changes: 1 addition & 2 deletions src/StimulusBundle/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"description": "Integration of @hotwired/stimulus into Symfony",
"version": "1.0.0",
"license": "MIT",
"module": "dist/loader.js",
"type": "module",
"main": "dist/loader.js",
"symfony": {
"needsPackageAsADependency": false,
"importmap": {
Expand Down
4 changes: 4 additions & 0 deletions src/Svelte/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Add support for Svelte 4.
Expand Down
3 changes: 1 addition & 2 deletions src/Svelte/assets/package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "@symfony/ux-svelte",
"description": "Integration of Svelte in Symfony",
"module": "dist/register_controller.js",
"type": "module",
"main": "dist/register_controller.js",
"version": "1.0.0",
"license": "MIT",
"symfony": {
Expand Down
File renamed without changes.
4 changes: 4 additions & 0 deletions src/Swup/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Change JavaScript package to `type: module`
Expand Down
3 changes: 1 addition & 2 deletions src/Swup/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"description": "Swup integration for Symfony",
"license": "MIT",
"version": "1.1.0",
"module": "dist/controller.js",
"type": "module",
"main": "dist/controller.js",
"types": "dist/controller.d.ts",
"symfony": {
"controllers": {
Expand Down
4 changes: 4 additions & 0 deletions src/TogglePassword/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Add Symfony 7 support.
Expand Down
3 changes: 1 addition & 2 deletions src/TogglePassword/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"description": "Toggle visibility of password inputs for Symfony Forms",
"license": "MIT",
"version": "1.0.0",
"module": "dist/controller.js",
"type": "module",
"main": "dist/controller.js",
"types": "dist/controller.d.ts",
"config": {
"css_source": "src/style.css"
Expand Down
4 changes: 4 additions & 0 deletions src/Translator/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Add Symfony 7 support.
Expand Down
3 changes: 1 addition & 2 deletions src/Translator/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"description": "Symfony Translator for JavaScript",
"license": "MIT",
"version": "1.0.0",
"module": "dist/translator_controller.js",
"type": "module",
"main": "dist/translator_controller.js",
"types": "dist/translator_controller.d.ts",
"symfony": {
"importmap": {
Expand Down
4 changes: 4 additions & 0 deletions src/Turbo/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Add Symfony 7 support.
Expand Down
3 changes: 1 addition & 2 deletions src/Turbo/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
"license": "MIT",
"private": true,
"version": "0.1.0",
"module": "dist/turbo_controller.js",
"type": "module",
"main": "dist/turbo_controller.js",
"types": "dist/turbo_controller.d.ts",
"symfony": {
"controllers": {
Expand Down
4 changes: 4 additions & 0 deletions src/Typed/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Change JavaScript package to `type: module`
Expand Down
3 changes: 1 addition & 2 deletions src/Typed/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"description": "Typed integration for Symfony",
"license": "MIT",
"version": "1.0.0",
"module": "dist/controller.js",
"type": "module",
"main": "dist/controller.js",
"types": "dist/controller.d.ts",
"symfony": {
"controllers": {
Expand Down
4 changes: 4 additions & 0 deletions src/Vue/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.13.2

- Revert "Change JavaScript package to `type: module`"

## 2.13.0

- Add Symfony 7 support.
Expand Down
3 changes: 1 addition & 2 deletions src/Vue/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"description": "Integration of Vue.js in Symfony",
"license": "MIT",
"version": "1.0.0",
"module": "dist/register_controller.js",
"type": "module",
"main": "dist/register_controller.js",
"types": "dist/register_controller.d.ts",
"symfony": {
"controllers": {
Expand Down

0 comments on commit a7fdbf8

Please sign in to comment.