Revert typing fix for hooks (done in another pr)

symfony · Jun 15, 2024 · ae2cf69 · ae2cf69
1 parent 93c65b3
commit ae2cf69
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 23 deletions.
diff --git a/src/LiveComponent/assets/dist/Component/index.d.ts b/src/LiveComponent/assets/dist/Component/index.d.ts
@@ -13,8 +13,8 @@ export type ComponentHooks = {
     'response:error': (backendResponse: BackendResponse, controls: {
         displayError: boolean;
     }) => MaybePromise;
-    'loading.state:started': (element: HTMLElement, request: BackendRequest) => MaybePromise;
-    'loading.state:finished': (element: HTMLElement) => MaybePromise;
+    'loading.state.started': (element: HTMLElement, request: BackendRequest) => MaybePromise;
+    'loading.state.finished': (element: HTMLElement) => MaybePromise;
     'model:set': (model: string, value: any, component: Component) => MaybePromise;
 };
 export type ComponentHookName = keyof ComponentHooks;

diff --git a/src/LiveComponent/assets/dist/HookManager.d.ts b/src/LiveComponent/assets/dist/HookManager.d.ts
@@ -1,7 +1,6 @@
-import type { ComponentHookName, ComponentHookCallback } from './Component';
 export default class {
     private hooks;
-    register<T extends string | ComponentHookName = ComponentHookName>(hookName: T, callback: ComponentHookCallback<T>): void;
-    unregister<T extends string | ComponentHookName = ComponentHookName>(hookName: T, callback: ComponentHookCallback<T>): void;
-    triggerHook<T extends string | ComponentHookName = ComponentHookName>(hookName: T, ...args: Parameters<ComponentHookCallback<T>>): void;
+    register(hookName: string, callback: (...args: any[]) => void): void;
+    unregister(hookName: string, callback: (...args: any[]) => void): void;
+    triggerHook(hookName: string, ...args: any[]): void;
 }
diff --git a/src/LiveComponent/assets/src/Component/index.ts b/src/LiveComponent/assets/src/Component/index.ts
@@ -22,8 +22,8 @@ export type ComponentHooks = {
     'request:started': (requestConfig: any) => MaybePromise,
     'render:finished': (component: Component) => MaybePromise,
     'response:error': (backendResponse: BackendResponse, controls: { displayError: boolean }) => MaybePromise,
-    'loading.state:started': (element: HTMLElement, request: BackendRequest) => MaybePromise,
-    'loading.state:finished': (element: HTMLElement) => MaybePromise,
+    'loading.state.started': (element: HTMLElement, request: BackendRequest) => MaybePromise,
+    'loading.state.finished': (element: HTMLElement) => MaybePromise,
     'model:set': (model: string, value: any, component: Component) => MaybePromise,
 };
 

diff --git a/src/LiveComponent/assets/src/HookManager.ts b/src/LiveComponent/assets/src/HookManager.ts
@@ -1,21 +1,13 @@
-import type { ComponentHookName, ComponentHookCallback } from './Component';
-
 export default class {
-    private hooks: Map<ComponentHookName | string, Array<(...args: any[]) => void>> = new Map();
+    private hooks: Map<string, Array<(...args: any[]) => void>> = new Map();
 
-    register<T extends string | ComponentHookName = ComponentHookName>(
-        hookName: T,
-        callback: ComponentHookCallback<T>
-    ): void {
+    register(hookName: string, callback: (...args: any[]) => void): void {
         const hooks = this.hooks.get(hookName) || [];
         hooks.push(callback);
         this.hooks.set(hookName, hooks);
     }
 
-    unregister<T extends string | ComponentHookName = ComponentHookName>(
-        hookName: T,
-        callback: ComponentHookCallback<T>
-    ): void {
+    unregister(hookName: string, callback: (...args: any[]) => void): void {
         const hooks = this.hooks.get(hookName) || [];
         const index = hooks.indexOf(callback);
         if (index === -1) {
@@ -26,10 +18,7 @@ export default class {
         this.hooks.set(hookName, hooks);
     }
 
-    triggerHook<T extends string | ComponentHookName = ComponentHookName>(
-        hookName: T,
-        ...args: Parameters<ComponentHookCallback<T>>
-    ): void {
+    triggerHook(hookName: string, ...args: any[]): void {
         const hooks = this.hooks.get(hookName) || [];
         hooks.forEach((callback) => callback(...args));
     }