[Translator] Create valid constant names for keys starting with numeric chars #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this fix @wolfgangweintritt! @Kocal, mind taking a look at this? |
Kocal
approved these changes
Apr 30, 2024
| @@ -166,7 +166,7 @@ private function generateConstantName(string $translationId): string | |||
|
|
|||
| $prefix = 0; | |||
| do { | |||
| $constantName = s($translationId)->ascii()->snake()->upper()->toString().($prefix > 0 ? '_'.$prefix : ''); | |||
| $constantName = preg_replace('/^(\d)/', '_$1', s($translationId)->ascii()->snake()->upper()->toString().($prefix > 0 ? '_'.$prefix : '')); | |||
There was a problem hiding this comment.
LGTM, but I would be in favor to use ->replaceMatches from s() instead of calling preg_replace directly
There was a problem hiding this comment.
Thanks for the review! Yeah I agree - I've changed it.
carsonbot
added
Status: Reviewed
…ic chars If the key of a translation started with a numeric character, the constant's name would also start with a numeric character, thus resulting in a JS syntax error. Prefixing the constant's name with an underscore makes it valid.
wolfgangweintritt
force-pushed
the
fix/constant-name-numeric
branch
from
c45f864
to
440b5ab
Compare
|
Thank you Wolfgang, great first PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the key of a translation started with a numeric character, the constant's name would also start with a numeric character, thus resulting in a JS syntax error. Prefixing the constant's name with an underscore makes it valid.