[Site] Make package box titles visible in dark mode #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stloyd
changed the title
smnandre
reviewed
Nov 29, 2023
Comment on lines
121
to
127
| color: #0A0A0A; | ||
| text-decoration: none; | ||
|
|
||
| [data-bs-theme="dark"] & { | ||
| filter: invert(1); | ||
| } | ||
| } |
There was a problem hiding this comment.
color: var(--bs-body-color);
text-decoration: none;
Simpler no ?
There was a problem hiding this comment.
"Depends" ;) If you mean to change it on line 121, then it will be changed to a light theme.
I followed already used code from: https://github.com/symfony/ux/blob/2.x/ux.symfony.com/assets/styles/sections/_header.scss#L39
There was a problem hiding this comment.
Because i wanted to invert all the colors, but if you look on other CSS properties, i tried to use CSS vars as much as possible because it's easier to read/maintain..
But i won't go against your suggestion :)) Iit's a good catch and a really nice attention to open this PR, and i'm really glad you did :)
|
Thank you Joseph! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now package box titles are really dark in the dark mode:
With that change it will look like:
