Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tom-select bootstrap4 css file to default config file #1316

Merged
merged 1 commit into from Dec 12, 2023
Merged

add tom-select bootstrap4 css file to default config file #1316

merged 1 commit into from Dec 12, 2023

Conversation

nayodahl
Copy link

Q A
Bug fix? yes
New feature? no
Issues Fix #1307
License MIT

Add tom-select bootstrap4 css file to default config file.
Without this, if you have replaced the bootstrap5.css value with a boostrap4 with value set to true, it will be replaced every time you perform a composer update (with the help of flex).

Like this :
image

Copy link
Collaborator

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, as TomSelect provides those 3 options, it can improve DX for people using Bootstrap 4

https://www.jsdelivr.com/package/npm/tom-select?tab=files&path=dist%2Fcss

@weaverryan
Copy link
Member

Thanks @nayodahl!

@weaverryan weaverryan merged commit 8801ac1 into symfony:2.x Dec 12, 2023
34 checks passed
@nayodahl nayodahl deleted the tom-select-boostrap4-config branch December 13, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Autocomplete] autoimport bootstrap option is reset to default when doing a composer update
3 participants