Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StimulusBundle] Added docs on TypeScript support #1345

Merged
merged 3 commits into from Jan 9, 2024
Merged

[StimulusBundle] Added docs on TypeScript support #1345

merged 3 commits into from Jan 9, 2024

Conversation

evertharmeling
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Issues #1335
License MIT

Follow-up on #1335, added more info on usage of TypeScript controllers support.

@evertharmeling evertharmeling changed the title Ts support [StimulusBundle] Added docs on TypeScript support Dec 19, 2023
@evertharmeling evertharmeling mentioned this pull request Dec 19, 2023
Merged
94noni
94noni approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@94noni 94noni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to add the link, but perhaps just as a tip bloc and devs would go read the package doc to install/configure

@weaverryan
Copy link
Member

Thanks Evert!

@weaverryan weaverryan merged commit 3c5d7a4 into symfony:2.x Jan 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@94noni 94noni 94noni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evertharmeling @weaverryan @94noni