[ChartJs] Add support for chart.js:^4.0 #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we add the "module" thing back now.. or in a distinct release to play safe ? cc @weaverryan |
weaverryan
reviewed
Jan 17, 2024
evertharmeling
force-pushed
the
chartjs-v4
branch
from
ac6d66c
to
56d925a
Compare
Not sure what's used in the github flow, but locally I tested it installing
|
weaverryan
added a commit
that referenced
this pull request
Jan 29, 2024
…ndencies per component (evertharmeling) This PR was squashed before being merged into the 2.x branch. Discussion ---------- Run tests for all supported versions defined for peerDependencies per component | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Issues | Relates to #1389 | License | MIT Refactored the `run-vitest-all.sh` script to loop over every component/workspace and check if there are `peerDependencies` who defined support for multiple versions (like https://github.com/symfony/ux/blob/2.x/src/Svelte/assets/package.json#L23). The script then runs the tests for every defined version for that library in that workspace. The greatest benefit of this change is that this needs no extra administration in keeping a `matrix` value up-to-date in the GitHub workflow for every library in a workspace that supports more than 1 version as it checks every `package.json` automatically. Tell me what you think about it! Cheers! - https://github.com/symfony/ux/actions/runs/7646573943/job/20835661388?pr=1417#step:6:200 -> `svelte@3.59.2` is installed - https://github.com/symfony/ux/actions/runs/7646573943/job/20835661388?pr=1417#step:6:259 -> `svelte@4.2.9` is installed Commits ------- 16fa514 Run tests for all supported versions defined for peerDependencies per component
|
Thanks Evert! |
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1202 has been merged, which solved the blockage of #610, the support for ChartJs v4 should be as simple as this PR :) and would replace #610.
🤞🏼 on the CI-flow