fix: use method from metadata for live component test helper

[daFish]

Q	A
Bug fix?	yes
New feature?	no
Issues	Fix #...
License	MIT

After #1218 has been released as part of 2.14.0 my tests fail. This change passes the actual method to the requests made by the test helper.

[weaverryan]

The change looks good, but I see that there are now failures inside the LiveComponent package itself.

[smnandre]

After #1218 has been released as part of 2.14.0 my tests fail. This change passes the actual method to the requests made by the test helper.

If you set "method: 'get'" on some of the tests that now fail, does it fix the problem or not ? (without the changes from this PR)

(just want to know if everything works in that case)

[daFish]

@smnandre Setting method: 'get' let's my test pass. Otherwise an Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException is thrown.

[smnandre]

From your PR, could you try to, when in POST, send "props" in JSON and not in the query string ?

Someything "like that" (did not test at all)

  $this->client->request('POST', $this->router->generate(
            $this->metadata->get('route'),
            [
                '_live_component' => $this->metadata->getName(),
            ]
        ), [
            'json' => ['props' => $props->getProps()]
        ]);

[daFish]

This did the trick:

            'POST',
            $this->router->generate(
                $this->metadata->get('route'),
                [
                    '_live_component' => $this->metadata->getName(),
                ]
            ),
            [
                'data' => json_encode(['props' => $props->getProps()]),
            ],
        );

[smnandre]

@daFish good news! Could you update your PR to include this change, and we'll see then if tests are OK or if there is something else to fix :)

[daFish]

Looks like there is more work todo. I'll see if I can do something about it. Any hints are appreciated.

[smnandre]

if ('POST' === $method = strtoupper($this->metadata->get('method'))) {
    $this->client->request(
        $method,
        $this->router->generate($this->metadata->get('route'), [
            '_live_component' => $this->metadata->getName(),
        ]),
        [
            'json' => ['props' => $props->getProps()],
        ],
    );
} else {
    $this->client->request($method, $this->router->generate(
        $this->metadata->get('route'),
        [
            '_live_component' => $this->metadata->getName(),
            'props' => json_encode($props->getProps(), flags: \JSON_THROW_ON_ERROR),
        ]
    ));
}

We need to handle both situations there

[daFish]

Of course - adjusted.

[smnandre]

I'm not sure this one need any change... do your tests fail there ?

[daFish]

Reverted.

[smnandre]

Do all your tests pass with this change? 😄

[daFish]

Yes, they do. And the checks here are also passing. But some more feedback from others would also be appreciated.

[smnandre]

Oops, we lost the flag :)

'data' => json_encode(['props' => $props->getProps()], flags: \JSON_THROW_ON_ERROR),

[daFish]

Failure unrelated.

[weaverryan]

Thanks Marcus!