Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigComponent] fix typo in compoundVariants documentation #1580

Merged
merged 1 commit into from Mar 4, 2024

Conversation

o0morgan0o
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
Issues -
License MIT

I think there is a typo in the documentation in the compoundVariants part, and it made me confused a little. The example in the doc was throwing An exception has been thrown during the rendering of a template ("Warning: foreach() argument must be of type array|object, string given").

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 3, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 3, 2024
Copy link
Collaborator

@WebMamba WebMamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Sorry about that!

@weaverryan
Copy link
Member

Thanks Morgan!

@weaverryan weaverryan merged commit 81f7d24 into symfony:2.x Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants