Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will support webpack encore, but i don't think we want to showcase it in the "default case", as it won't be there for people installing a new Symfony webapp.
So those two files could probably be explained on the documentation, but right there it's kinda the opposite of what we're trying to promote for easy plug-n-play DX.
WDYT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean those can be removed completely ?
Why not, and somewhere else document that such file may exists if webpack encore is still use in the app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean.. it's kinda odd to brand "assetmapper" as "no-npm-tools" and showcase them here, right ? So maybe we can do the jumb.
Another idea would be to have some tabbed content here with "assetmapper / webpack" but i feel on this place, maybe we should be the most direct/simple we can.