Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Command make:autocomplete-field output a doc compliant class #1699

Conversation

lucbu
Copy link

@lucbu lucbu commented Apr 8, 2024

Q A
Bug fix? yes
New feature? no
Issues n/a
License MIT

The make:autocomplete-field command outputs a bad formatted file with a deprecated Parent and a query_builder.
I replaced the parent and removed the query_builder line just like in the doc.

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Apr 8, 2024
@lucbu lucbu force-pushed the maker-autocompletefield-use-baseentityautocompletefield branch from 1f120cd to 2bf23e9 Compare April 8, 2024 19:11
@lucbu lucbu changed the title Command make:autocomplete-field output a doc compliant class [Autocomplete] Command make:autocomplete-field output a doc compliant class Apr 8, 2024
@lucbu lucbu force-pushed the maker-autocompletefield-use-baseentityautocompletefield branch from 2bf23e9 to 6668d64 Compare April 8, 2024 19:13
@lucbu lucbu marked this pull request as draft April 8, 2024 19:14
@lucbu lucbu marked this pull request as ready for review April 8, 2024 19:16
@lucbu lucbu requested a review from smnandre April 9, 2024 07:21
Copy link
Collaborator

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 9, 2024
@kbond kbond force-pushed the maker-autocompletefield-use-baseentityautocompletefield branch from 2a91b79 to 7dfab08 Compare April 9, 2024 17:53
@kbond
Copy link
Member

kbond commented Apr 9, 2024

Thank you @lucbu.

@kbond kbond merged commit f8d7faa into symfony:2.x Apr 9, 2024
4 checks passed
@lucbu lucbu deleted the maker-autocompletefield-use-baseentityautocompletefield branch April 10, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants