[Autocomplete] Use choice_value in the WrappedEntityTypeAutocompleter in EntityAutocompleteField

[jakubtobiasz]

Q	A
Bug fix?	yes
New feature?	no
Issues
License	MIT

Currently despite setting the choice_value the \Symfony\UX\Autocomplete\Form\WrappedEntityTypeAutocompleter uses the id value of the entity. This PR allows to override the autocomplete result value in the entity autocomplete fields.

[kbond]

@jakubtobiasz, thanks for this PR! Do you think this could be considered a bug fix?

[jakubtobiasz]

Hi @kbond,
considering the definition from the Wikipedia

A software bug is an error, flaw or fault in the design, development, or operation of computer software that causes it to produce an incorrect or unexpected result, or to behave in unintended ways.

The

that causes it to produce an (...) unexpected result

part convinces me that might be categorized as a bugfix. We were pretty surprised it doesn't work that way :D.

---

I've updated the description, the question is whether there should be a 2.16.1 version or we should expect 2.17 as a next version.

[kbond]

We were pretty surprised it doesn't work that way :D.

Me too!

Anyway, it's just semantics and I really just wanted to clarify that this "felt like the intended use" which you have done.

The next version will be 2.17.0 so no worries about the changelog.

[smnandre]

Suggested change

	- Allow defining custom values for the autocomplete results with using `choice_value` option in entity autocomplete fields
	- Allow `choice_value` option in entity autocomplete fields #1723

(just a suggestion)

[smnandre]

Thank you @jakubtobiasz !

[kbond]

Thank you Jacob.

[norkunas]

this was a duplicate of #1328