Allow debuging components with union typed props #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienlucas
force-pushed
the
debug-union-type-props
branch
from
a02089d
to
8b2719c
Compare
WebMamba
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Hey @adrienlucas it's good to see you here! Thanks for the fix! 😁
carsonbot
added
Status: Reviewed
smnandre
approved these changes
Apr 17, 2024
|
Thank you Adrien. |
|
Thank you guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a component has a property with an union type, the debug command crash with
Attempted to call an undefined method named "getName" of class "ReflectionUnionType". This fix the issue.