-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Translator] Add configuration to filter dumped translations by domain #1930
[Translator] Add configuration to filter dumped translations by domain #1930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution and splitting #1927 into two PR, that was a lot easier to review! :)
} | ||
if (0 !== \count($this->includedDomains) && !\in_array($domain, $this->includedDomains, true)) { | ||
continue; | ||
} | ||
foreach ($catalogue->all($domain) as $id => $message) { | ||
$realDomain = $catalogue->has($id, $domain.MessageCatalogueInterface::INTL_DOMAIN_SUFFIX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe leverage CatalogueMetadataAwareInterface here ?
d96b0f7
to
d66804a
Compare
src/Translator/src/DependencyInjection/UxTranslatorExtension.php
Outdated
Show resolved
Hide resolved
src/Translator/src/DependencyInjection/UxTranslatorExtension.php
Outdated
Show resolved
Hide resolved
9d6f736
to
e41a908
Compare
So were are we there ? :) Do you need help for something ? Is the doc ready ? |
@smnandre Yes that should be it, the doc as well. I'm just not sure what version I should use in the changelog entry. |
2.19 no ? |
47a7009
to
3135d1e
Compare
The failing test surprises me a bit ... @WebMamba any idea ? I feel we may have exposed more than we wanted |
Looks like this is related to the PR: #1940. Hummm the test looks flaky. I don't think this is related to this PR though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just questioning the config choice
18a0ad4
to
f36d05d
Compare
f36d05d
to
2b56e4a
Compare
This is great @maelanleborgne, thank you! |
Add two config entries
included_domains
andexcluded_domains
to filter which translation domains should be dumped.If
included_domains
is empty, it is not taken into account.TODO: