[Translator] Add configuration to filter dumped translations by domain #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
smnandre
reviewed
Jun 20, 2024
smnandre
reviewed
Jun 20, 2024
smnandre
reviewed
Jun 20, 2024
smnandre
reviewed
Jun 20, 2024
smnandre
reviewed
Jun 20, 2024
| } | ||
| if (0 !== \count($this->includedDomains) && !\in_array($domain, $this->includedDomains, true)) { | ||
| continue; | ||
| } | ||
| foreach ($catalogue->all($domain) as $id => $message) { | ||
| $realDomain = $catalogue->has($id, $domain.MessageCatalogueInterface::INTL_DOMAIN_SUFFIX) |
There was a problem hiding this comment.
Maybe leverage CatalogueMetadataAwareInterface here ?
maelanleborgne
force-pushed
the
feature/translator-filter-domains
branch
from
d96b0f7
to
d66804a
Compare
smnandre
reviewed
Jun 22, 2024
src/Translator/src/DependencyInjection/UxTranslatorExtension.php
Outdated
Show resolved
Hide resolved
smnandre
reviewed
Jun 22, 2024
src/Translator/src/DependencyInjection/UxTranslatorExtension.php
Outdated
Show resolved
Hide resolved
smnandre
reviewed
Jun 22, 2024
smnandre
reviewed
Jun 22, 2024
smnandre
reviewed
Jun 22, 2024
maelanleborgne
force-pushed
the
feature/translator-filter-domains
branch
from
9d6f736
to
e41a908
Compare
|
So were are we there ? :) Do you need help for something ? Is the doc ready ? |
@smnandre Yes that should be it, the doc as well. I'm just not sure what version I should use in the changelog entry. |
|
2.19 no ? |
maelanleborgne
force-pushed
the
feature/translator-filter-domains
branch
from
47a7009
to
3135d1e
Compare
|
The failing test surprises me a bit ... @WebMamba any idea ? I feel we may have exposed more than we wanted |
|
Looks like this is related to the PR: #1940. Hummm the test looks flaky. I don't think this is related to this PR though |
kbond
reviewed
Jul 4, 2024
kbond
reviewed
Jul 4, 2024
maelanleborgne
force-pushed
the
feature/translator-filter-domains
branch
from
18a0ad4
to
f36d05d
Compare
kbond
approved these changes
Jul 9, 2024
carsonbot
added
Status: Reviewed
kbond
force-pushed
the
feature/translator-filter-domains
branch
from
f36d05d
to
2b56e4a
Compare
|
This is great @maelanleborgne, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two config entries
included_domainsandexcluded_domainsto filter which translation domains should be dumped.If
included_domainsis empty, it is not taken into account.TODO: