[Turbo] Make the Broadcast attribute repeatable #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Jul 7, 2022
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| ## 2.2 | |||
|
|
|||
| - The topics defined in the Broadcast attribute now support expression language when prefixed with `@=`. | |||
| - The topics defined in the `Broadcast` attribute now support expression language when prefixed with `@=`. | |||
| - The `Broadcast` attribute can now be repeated, this is convenient to render several Turbo Streams Twig templates for the same change | |||
There was a problem hiding this comment.
Minor - but this will be for 2.3
|
Gave it a try and it works just fine, thank you Kévin! |
weaverryan
force-pushed
the
ux/feat/repeatable-attribute
branch
from
5f5abb0
to
298229e
Compare
|
Thank you Kévin! |
weaverryan
added a commit
that referenced
this pull request
Jul 8, 2022
…erryan) This PR was merged into the 2.x branch. Discussion ---------- [Turbo] Moving repeatable Broadcast changelog to 2.3 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Tickets | None | License | MIT CHANGELOG tweak needed for #387 Commits ------- 6defd83 [Turbo] Moving repeatable Broadcast changelog to 2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the
Broadcastattribute to be used many times.This is convenient to update different pages (ex: the list and the detail page) containing the same data but rendered differently.
Ex: