Fix double escaping in stimulus DTOs when using toArray() in combination with form methods #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion with form methods toArray() should return an array with non-escaped attribute key-value pairs, because they will be escaped when printed.
jeroennoten
force-pushed
the
feature/fix-double-escaping-in-stimulus-dtos
branch
from
06214d7
to
0d40126
Compare
weaverryan
approved these changes
Jan 18, 2023
|
Excellent PR Jeroen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a double-escaping bug when the
toArray()methods are used in combination with theform_functions, as described in the README.toArray()should return an array with non-escaped attribute key-value pairs, because they will be escaped when printed.Therefore, I moved the escaping of the values to the
toString()methods and I added some additional tests for the DTO classes to verify the change.This additionally fixes a missed escape for the
data-[controller]-[key]-classattribute values.