Use the apply-options-callback method for the eslint-loader

symfony · May 8, 2018 · 0738691 · 0738691
1 parent 87e1a02
commit 0738691
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/lib/loaders/eslint.js b/lib/loaders/eslint.js
@@ -10,6 +10,7 @@
 'use strict';
 
 const loaderFeatures = require('../features');
+const applyOptionsCallback = require('../utils/apply-options-callback');
 
 /**
  * @param {WebpackConfig} webpackConfig
@@ -29,12 +30,6 @@ module.exports = {
             }
         };
 
-        webpackConfig.eslintLoaderOptionsCallback.apply(
-            // use eslintLoaderOptions as the this variable
-            eslintLoaderOptions,
-            [eslintLoaderOptions]
-        );
-
-        return eslintLoaderOptions;
+        return applyOptionsCallback(webpackConfig.eslintLoaderOptionsCallback, eslintLoaderOptions);
     }
 };
diff --git a/test/loaders/eslint.js b/test/loaders/eslint.js
@@ -54,4 +54,16 @@ describe('loaders/eslint', () => {
         expect(Object.keys(actualOptions)).to.have.lengthOf(3);
         expect(actualOptions.emitWarning).to.equal(false);
     });
+
+    it('getOptions() with a callback that returns an object', () => {
+        const config = createConfig();
+        config.enableEslintLoader((options) => {
+            options.custom_option = 'foo';
+
+            return { foo: true };
+        });
+
+        const actualOptions = eslintLoader.getOptions(config);
+        expect(actualOptions).to.deep.equals({ foo: true });
+    });
 });