chore(cr): move tests into

symfony · Mar 1, 2019 · 39cb9bd · 39cb9bd
1 parent bc0e9bf
commit 39cb9bd
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 27 deletions.
diff --git a/test/config-generator.js b/test/config-generator.js
@@ -1014,4 +1014,30 @@ describe('The config-generator function', () => {
             });
         });
     });
+
+    describe('Test configureLoaderRule()', () => {
+        it('configure rule for "eslint"', () => {
+            const config = createConfig();
+            config.setPublicPath('/');
+            config.enableEslintLoader();
+            config.configureLoaderRule('eslint', (loader) => {
+                loader.test = /\.(jsx?|vue)/;
+            });
+
+            const webpackConfig = configGenerator(config);
+            const eslintLoader = webpackConfig.module.rules.find(rule => rule.loader === 'eslint-loader');
+
+            expect(eslintLoader).to.deep.equals({
+                test: /\.(jsx?|vue)/,
+                enforce: 'pre',
+                exclude: /node_modules/,
+                loader: 'eslint-loader',
+                options: {
+                    cache: true,
+                    emitWarning: true,
+                    parser: 'babel-eslint'
+                }
+            });
+        });
+    });
 });
diff --git a/test/loaders/eslint.js b/test/loaders/eslint.js
@@ -12,9 +12,7 @@
 const expect = require('chai').expect;
 const WebpackConfig = require('../../lib/WebpackConfig');
 const RuntimeConfig = require('../../lib/config/RuntimeConfig');
-const configGenerator = require('../../lib/config-generator');
 const eslintLoader = require('../../lib/loaders/eslint');
-const isWindows = (process.platform === 'win32');
 
 function createConfig() {
     const runtimeConfig = new RuntimeConfig();
@@ -79,29 +77,4 @@ describe('loaders/eslint', () => {
         const actualOptions = eslintLoader.getOptions(config);
         expect(actualOptions).to.deep.equals({ foo: true });
     });
-
-    it('configure ESLint loader rule', () => {
-        const config = createConfig();
-        config.outputPath = isWindows ? 'C:\\tmp\\public' : '/tmp/public';
-        config.setPublicPath('/');
-        config.enableEslintLoader();
-        config.configureLoaderRule('eslint', (loader) => {
-            loader.test = /\.(jsx?|vue)/;
-        });
-
-        const webpackConfig = configGenerator(config);
-        const eslintLoader = webpackConfig.module.rules.find(rule => rule.loader === 'eslint-loader');
-
-        expect(eslintLoader).to.deep.equals({
-            test: /\.(jsx?|vue)/,
-            enforce: 'pre',
-            exclude: /node_modules/,
-            loader: 'eslint-loader',
-            options: {
-                cache: true,
-                emitWarning: true,
-                parser: 'babel-eslint'
-            }
-        });
-    });
 });