feature #75 Making enableTypeScriptLoader() options callback optional…

… (weaverryan)

This PR was merged into the master branch.

Discussion
----------

Making enableTypeScriptLoader() options callback optional

The `enableTypeScriptLoader()` should allow for no callback function - it's probably not needed in most cases.

Ping @davidmpaz

Commits
-------

0e0f3de Making enableTypeScriptLoader() options callback optional

index.js

@@ -345,17 +345,19 @@ module.exports = {
     /**
      * Call this if you plan on loading TypeScript files.
      *
+     * Encore.enableTypeScriptLoader()
+     *
+     * Or, configure the ts-loader options:
+     *
      * Encore.enableTypeScriptLoader(function(tsConfig) {
-     *      // change the tsConfig
+     *      // https://github.com/TypeStrong/ts-loader/blob/master/README.md#loader-options
+     *      // tsConfig.silent = false;
      * });
      *
-     * Supported configuration options:
-     * @see https://github.com/TypeStrong/ts-loader/blob/master/README.md#available-options
-     *
      * @param {function} callback
      * @return {exports}
      */
-    enableTypeScriptLoader(callback) {
+    enableTypeScriptLoader(callback = () => {}) {
         webpackConfig.enableTypeScriptLoader(callback);
     },
 

lib/WebpackConfig.js

@@ -226,7 +226,7 @@ class WebpackConfig {
         this.useReact = true;
     }
 
-    enableTypeScriptLoader(callback) {
+    enableTypeScriptLoader(callback = () => {}) {
         this.useTypeScriptLoader = true;
 
         if (typeof callback !== 'function') {

test/WebpackConfig.js

@@ -292,10 +292,6 @@ describe('WebpackConfig object', () => {
             expect(() => {
                 config.enableTypeScriptLoader('FOO');
             }).to.throw('must be a callback function');
-
-            expect(() => {
-                config.enableTypeScriptLoader();
-            }).to.throw('must be a callback function');
         });
     });