Add a warning when calling addCacheGroup() with 'vendors' or the same…

… than in createSharedEntry()
symfony · Mar 27, 2020 · 7e32b0b · 7e32b0b
1 parent e4095b3
commit 7e32b0b
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/lib/config/validator.js b/lib/config/validator.js
@@ -80,9 +80,13 @@ class Validator {
 
     _validateCacheGroupNames() {
         for (const groupName of Object.keys(this.webpackConfig.cacheGroups)) {
-            if (['defaultVendors', 'default'].includes(groupName)) {
+            if (['vendors', 'defaultVendors', 'default'].includes(groupName)) {
                 logger.warning(`Passing "${groupName}" to addCacheGroup() is not recommended, as it will override the built-in cache group by this name.`);
             }
+
+            if (groupName === this.webpackConfig.sharedCommonsEntryName) {
+                logger.warning('Using the same name when calling createSharedEntry() and addCacheGroup() is not recommended.');
+            }
         }
     }
 }

diff --git a/test/config/validator.js b/test/config/validator.js
@@ -113,4 +113,22 @@ describe('The validator function', () => {
         expect(logger.getMessages().warning).to.have.lengthOf(1);
         expect(logger.getMessages().warning[0]).to.include('Passing "defaultVendors" to addCacheGroup() is not recommended');
     });
+
+    it('warning with addCacheGroup() and a similar createSharedEntry() name', () => {
+        const config = createConfig();
+        config.outputPath = '/tmp/public/build';
+        config.setPublicPath('/build');
+        config.addEntry('main', './main');
+        config.createSharedEntry('foo', './foo.js');
+        config.addCacheGroup('foo', {
+            test: /[\\/]main/,
+        });
+
+        logger.reset();
+        logger.quiet();
+        validator(config);
+
+        expect(logger.getMessages().warning).to.have.lengthOf(1);
+        expect(logger.getMessages().warning[0]).to.include('Using the same name when calling createSharedEntry() and addCacheGroup() is not recommended.');
+    });
 });