bug #132 Reversing pathinfo logic to avoid extra comments (weaverryan)

This PR was merged into the master branch. Discussion ---------- Reversing pathinfo logic to avoid extra comments This creates extra comments in the final .js files, to help debugging. This was a mistake when originally added - the logic was reversed. Fixes #120 Commits ------- 2d0cb94 reversing pathinfo logic
symfony · Aug 5, 2017 · a37b6f0 · a37b6f0
2 parents bed57b3 + 2d0cb94
commit a37b6f0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/config-generator.js b/lib/config-generator.js
@@ -107,7 +107,7 @@ class ConfigGenerator {
             // will use the CDN path (if one is available) so that split
             // chunks load internally through the CDN.
             publicPath: this.webpackConfig.getRealPublicPath(),
-            pathinfo: this.webpackConfig.isProduction()
+            pathinfo: !this.webpackConfig.isProduction()
         };
     }
 

diff --git a/test/functional.js b/test/functional.js
@@ -505,6 +505,11 @@ describe('Functional tests using webpack', function() {
                     'main.js',
                     '// comments in no_require.js'
                 );
+                // check for any webpack-added comments
+                webpackAssert.assertOutputFileDoesNotContain(
+                    'main.js',
+                    '/*!'
+                );
                 // extra spaces should not live in the CSS file
                 webpackAssert.assertOutputFileDoesNotContain(
                     'styles.css',