Skip to content

Commit

Permalink
bug #765 Fixing babel.config.js filename in message (weaverryan)
Browse files Browse the repository at this point in the history
This PR was merged into the master branch.

Discussion
----------

Fixing babel.config.js filename in message

Introduced in #738 - @jdreesen I think this was just a typo? Can you confirm that my PR is right?

Thanks!

Commits
-------

c163909 fixing babel.config.js filename in message
  • Loading branch information
weaverryan committed May 11, 2020
2 parents b722a0e + c163909 commit cd661d3
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/WebpackConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ class WebpackConfig {
}

if (this.doesBabelRcFileExist()) {
logger.warning('The "callback" argument of configureBabel() will not be used because your app already provides an external Babel configuration (e.g. a ".babelrc" or "babelrc.config.js" file or "babel" key in "package.json"). Use null as a first argument to remove that warning.');
logger.warning('The "callback" argument of configureBabel() will not be used because your app already provides an external Babel configuration (e.g. a ".babelrc" or "babel.config.js" file or "babel" key in "package.json"). Use null as a first argument to remove that warning.');
}
}

Expand All @@ -416,7 +416,7 @@ class WebpackConfig {
}

if (this.doesBabelRcFileExist() && !allowedOptionsWithExternalConfig.includes(normalizedOptionKey)) {
logger.warning(`The "${normalizedOptionKey}" option of configureBabel() will not be used because your app already provides an external Babel configuration (e.g. a ".babelrc" or "babelrc.config.js" file or "babel" key in "package.json").`);
logger.warning(`The "${normalizedOptionKey}" option of configureBabel() will not be used because your app already provides an external Babel configuration (e.g. a ".babelrc" or "babel.config.js" file or "babel" key in "package.json").`);
continue;
}

Expand Down Expand Up @@ -463,7 +463,7 @@ class WebpackConfig {
}

if (this.doesBabelRcFileExist()) {
throw new Error('The "callback" argument of configureBabelPresetEnv() will not be used because your app already provides an external Babel configuration (e.g. a ".babelrc" or "babelrc.config.js" file or "babel" key in "package.json").');
throw new Error('The "callback" argument of configureBabelPresetEnv() will not be used because your app already provides an external Babel configuration (e.g. a ".babelrc" or "babel.config.js" file or "babel" key in "package.json").');
}

this.babelPresetEnvOptionsCallback = callback;
Expand Down

0 comments on commit cd661d3

Please sign in to comment.