Figure out the way to test different deps than the locked ones #39

stof · 2017-06-20T10:49:34Z

As this package is used as a library by others, we have no guarantee that they will install dependencies being exactly the same than our locked deps.
So it would be great to have some CI job resolving deps separately from the lock.

We need to figure out what the Node.js best practices around that are, and apply them on our CI.

Currently it's not possible to run encore after installing dependencies with `NPM`. Error in console: ``` $ npx encore /node_modules/@symfony/webpack-encore/bin/encore.js:2 basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')") ^^^^^^^ SyntaxError: missing ) after argument list ``` Only after using yarn the problem was solved. The lock file is a must, we will know everyone's dependencies are in the same situation. Unfortunately the `package-lock.json` file from `NPM@5` is not supported by `yarn` yarnpkg/yarn#3614 Related: symfony/webpack-encore#39

steven-prybylynskyi · 2017-11-10T11:06:50Z

We could support npm and yarn by running both npm install and yarn add whenever a new package is added.
Unfortunately there's no guarantee that package-lock.json and yarn.lock will be equivalent. It's because some dependencies may commit package-lock.json and others yarn.lock

Unfortunately the package-lock.json file from NPM@5 is not supported by yarn
yarnpkg/yarn#3614

stof · 2017-11-10T11:11:29Z

@pribilinskiy I don't care about supporting both NPM and Yarn for people contributing to this project (people using this project are already free to use what they want).
This issue is about figuring out what the Node best practices are regarding versions of deps used on CI for libraries.
The lock file is a root-only thing anyway (like in composer).

… the dependencies (Lyrkan) This PR was squashed before being merged into the master branch (closes #403). Discussion ---------- Add new Travis jobs to test lowest/highest versions of all the dependencies This PR adds two Travis jobs that allow to test the lowest and highest versions of all the dependencies (including the dev ones since the version ranges are used by the package helper). I wasn't sure about the method to use for the lowest versions since we can't really guess them without calling the npm's registry API. So, if someone has a better idea... :) Note that both jobs currently fail for the following reasons: - Lowest versions: This isn't really an issue since it seems related to Webpack 4 for which we haven't released a version yet. We could increase the minimum version to match the one from the `yarn.lock` file before releasing. - Highest versions: This is caused by the last version of the `mini-css-extract-plugin` (0.4.3) which doesn't seem to work well with the `webpack-manifest-plugin` anymore (see webpack-contrib/mini-css-extract-plugin#177 (comment)). Closes #39. Commits ------- bcabda6 Add some missing 'return' statements 0161000 Remove hardcoded sass-loader version in addPackagesVersionConstraint test 7abea75 Add new Travis jobs to test lowest/highest versions of all the dependencies

stof mentioned this issue Jun 20, 2017

Update dependencies for webpack 3 (when possible) #38

Closed

steven-prybylynskyi mentioned this issue Nov 10, 2017

Explain why yarn is more preferred than npm symfony/symfony-docs#8615

Closed

Lyrkan mentioned this issue Oct 7, 2018

Add new Travis jobs to test lowest/highest versions of all the dependencies #403

Merged

Lyrkan added the HasPR label Oct 7, 2018

weaverryan closed this as completed in #403 Oct 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Figure out the way to test different deps than the locked ones #39

Figure out the way to test different deps than the locked ones #39

stof commented Jun 20, 2017 •

edited

steven-prybylynskyi commented Nov 10, 2017 •

edited

stof commented Nov 10, 2017 •

edited

Figure out the way to test different deps than the locked ones #39

Figure out the way to test different deps than the locked ones #39

Comments

stof commented Jun 20, 2017 • edited

steven-prybylynskyi commented Nov 10, 2017 • edited

stof commented Nov 10, 2017 • edited

stof commented Jun 20, 2017 •

edited

steven-prybylynskyi commented Nov 10, 2017 •

edited

stof commented Nov 10, 2017 •

edited