-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any way to use ts-loader ^5.1.1 or newer? #431
Comments
Hey @msheakoski! Hmm. Actually, Line 85 in 78f28a5
ts-loader to your package.json and managing whatever version you need.
Are you seeing something different? Is Cheers! |
@weaverryan I have ts-loader under devDependencies because that is what the documentation advised as of 0.20. I noticed that the docs have since changed to allow for encore to prompt for missing packages, but even then, it is suggested to install as a dev dependency:
Should dependencies now be installed as non-dev? |
well, it depends whether you run encore on a server where you install dev dependencies or no. What is important is that ts-loader is installed when you run encore. |
The most DX-friendly route in my opinion is to keep the package install suggestions as dev dependencies and bump ts-loader to at least ^5.0.0. Although most Symfony users would be fine installing packages as either dev or non-dev, there may be some projects that have Symfony plus supporting Node.js code (maybe a websocket server for example) in the same repo and they would not want build-time packages installed in the production environment. |
It's nice to be able to periodically run
yarn upgrade --latest
and have your package.json update to the latest versions of everything, but ts-loader on encore 0.21 seems to be locked at ^4.3.0 and instead I need to manually type out every dependency to update minus ts-loader to avoid getting the newer version. This was also an issue with encore 0.20 which was locked into an even older version of ts-loader and I was surprised to see the same issue on the latest encore.Is it possible to bump the dependency requirement to ^5.1.1 which is the oldest 5.x version that contains a bug fix?
The text was updated successfully, but these errors were encountered: