updating css-loader dep and ts-loader dev dep #440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Nov 9, 2018
| @@ -82,7 +82,7 @@ | |||
| "sinon": "^2.3.4", | |||
| "stylus": "^0.54.5", | |||
| "stylus-loader": "^3.0.2", | |||
| "ts-loader": "^4.3.0", | |||
| "ts-loader": "^5.3.0", | |||
There was a problem hiding this comment.
This is in devDependencies, so it really just means that we test against this version - the user can install something lower, but they will get a warning. We could also set this to ^5.0.0, which would mean we would test against 5.0.0 in one our test suites. When the user needs to install this, they would be give the command yarn add ts-loader ^5.0.0, but that should install the latest version anyways.
javiereguiluz
approved these changes
Nov 9, 2018
This is needed for the latest version of css-loader, which does not handle this
weaverryan
force-pushed
the
bump-vendor-deps
branch
from
e9dd099
to
241e8ae
Compare
|
This has one minor failing test, but is otherwise ready for review |
... and also that, due to some old bad code, the .map files were not being removed correctly for style entries in production.
Lyrkan
approved these changes
Nov 13, 2018
stof
reviewed
Nov 16, 2018
| chunk.files.forEach((filename) => { | ||
| // loop in reverse, to avoid issues as we remove items from chunk.files | ||
| for (let i = chunk.files.length - 1; i >= 0; --i) { | ||
| let filename = chunk.files[i]; | ||
| if (/\.js(\.map)?(\?[^.]*)?$/.test(filename)) { | ||
| fileDeleteCount++; | ||
| // remove the output file | ||
| delete compilation.assets[filename]; | ||
| // remove the file, so that it does not dump in the manifest | ||
| chunk.files.splice(chunk.files.indexOf(filename), 1); |
There was a problem hiding this comment.
chunk.files.indexOf(filename) could be i instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #438 and fixes #431 and I believe fixes #432
This PR is more interesting than I expected! The latest version of
css-loader(1.0) does not have theminimizeoption. Even though (until now) the older version was locked on ourpackage.json, it may have been possible for users to be using a new version (I believe that should not be possible, but node deps can do strange things).