Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.21.1] Encore.enableSourceMaps(!Encore.isProduction()) always generates CSS maps #454

Closed
jfcherng opened this issue Nov 16, 2018 · 2 comments
Closed

[0.21.1] Encore.enableSourceMaps(!Encore.isProduction()) always generates CSS maps #454

jfcherng opened this issue Nov 16, 2018 · 2 comments
Labels
HasPR

Comments

@jfcherng
Copy link

As the title.
@weaverryan weaverryan mentioned this issue Nov 16, 2018
Merged
@weaverryan
Copy link
Member

See #457 - thanks for opening the fast issue!

@weaverryan weaverryan reopened this Nov 16, 2018
@weaverryan
Copy link
Member

didn't mean to close QUITE yet :)

weaverryan added a commit that referenced this issue Nov 16, 2018
@weaverryan
bug #457 Conditionally add some logic to prevent accidental sourcemap…
fc39d6f 
…s (weaverryan)

This PR was merged into the master branch.

Discussion
----------

Conditionally add some logic to prevent accidental sourcemaps

Fixes #454

Commits
-------

06d66b6 Conditionally add some logic to prevent accidental sourcemaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HasPR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weaverryan @jfcherng