Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ts-loader 9 #993

Closed
bobvandevijver opened this issue May 31, 2021 · 5 comments
Closed

Support ts-loader 9 #993

bobvandevijver opened this issue May 31, 2021 · 5 comments

Comments

@bobvandevijver
Copy link
Contributor

ts-loader v9 is currently not supported.
@Kocal
Copy link
Contributor

Kocal commented May 31, 2021 •
edited

Breaking changes: https://github.com/TypeStrong/ts-loader/blob/main/CHANGELOG.md#v900

What should we do about the Node.js version? Since Encore provides support for Node.js 10.
But since Node.js 10 is not maintened anymore, maybe we can drop it.

WDYT?

@bobvandevijver
Copy link
Contributor Author

It can still be supported as with #983, so once that has been merged allowing v9 for ts-loader doesn't seem like a problem.

Dropping Node 10 was not the favorite option of @weaverryan due to Ubuntu LTS (see the discussing in #983).

@Kocal
Copy link
Contributor

Kocal commented May 31, 2021

Dropping Node 10 was not the favorite option of @weaverryan due to Ubuntu LTS (see the discussing in #983).

Hum, it reminds me the discussion on #912... I still don't understand why we would prefer to get stuck with an outdated Node.js version offered by Ubuntu (LTS or not), instead of using the PPA from Node.js, or nvm, or n... 😞 w/e

@weaverryan
Copy link
Member

It's more: we want people using Ubuntu's LTS to be able to easily use Symfony or Encore, without needing to go outside the normal package manager to install a newer version of PHP or Node.

However, I also recognize that Node is especially tricky, since we seem to be an outlier in doing this - most packages drop Node support ASAP :)

@bobvandevijver
Copy link
Contributor Author

Note that this no longer holds for Symfony 6 as that requires at least PHP 8, which is not available (without PPA) in Ubuntu LTS or the next stable Debian... I know that the choice was done for technical reasons as PHP 8 has several benefits, but dropping an officially unsupported version seems to be a similar choice.

@bobvandevijver bobvandevijver mentioned this issue Jun 1, 2021
Closed
Kocal added a commit to Kocal/webpack-encore that referenced this issue Jun 3, 2021
@Kocal
Allow ts-loader ^9.0.0, close symfony#993
30cc073 
Like symfony#999, the only breaking change is that the minimum supported version of Node.js is 12.0.0,
see https://github.com/TypeStrong/ts-loader/blob/main/CHANGELOG.md#v900
weaverryan added a commit that referenced this issue Jun 8, 2021
@weaverryan
feature #1000 Allow ts-loader ^9.0.0, close #993 (Kocal)
4f791f6 
This PR was squashed before being merged into the main branch.

Discussion
----------

Allow ts-loader ^9.0.0, close #993

Like #999, the only breaking change is that the minimum supported version of Node.js is 12.0.0,
see https://github.com/TypeStrong/ts-loader/blob/main/CHANGELOG.md#v900

**EDIT:** PR #1000 🤯

**EDIT 2:** Looks like something broke. It happens since 9.0.0 (exact version) but I don't know what happens.

**EDIT 3:** Added TypeScript types for `.vue`, and it's working fine. Not sure if it's really a BC break, I expect most of people using Vue 3 + TypeScript already using a `vue-shims.d.ts` file... 😕

Commits
-------

4587706 Allow ts-loader ^9.0.0, close #993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weaverryan @bobvandevijver @Kocal