Always add a hash to the name of the files created by the default assets loaders #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Jul 26, 2017
lib/config-generator.js
Outdated
| @@ -127,15 +127,15 @@ class ConfigGenerator { | |||
| test: /\.(png|jpg|jpeg|gif|ico|svg)$/, | |||
| loader: 'file-loader', | |||
| options: { | |||
| name: `images/[name]${this.webpackConfig.useVersioning ? '.[hash]' : ''}.[ext]`, | |||
| name: 'images/[name].[hash].[ext]', | |||
There was a problem hiding this comment.
What do you think about using a shorter hash - like [hash:8]? The longer seems overkill... I should have done this originally.
There was a problem hiding this comment.
Done, no idea what's up with AppVeyor though (same thing for #103)
|
One minor comment - but this looks great - really nice job with the test! |
|
Thank you @Lyrkan! Test failure is from master and unrelated - I'll fix it :) |
weaverryan
added a commit
that referenced
this pull request
Jul 27, 2017
…fault assets loaders (Lyrkan) This PR was squashed before being merged into the master branch (closes #110). Discussion ---------- Always add a hash to the name of the files created by the default assets loaders This PR modifies the configuration of the default assets loaders so a `[hash]` is always added to the output file names, even if versioning is disabled. It basically prevents having two files with the same name (but in a different directory) overwriting each other during build. This closes #73 and was further discussed in #103. Commits ------- d5cd482 Use [hash:8] for images and fonts filenames instead of [hash] 874235d Modify images/fonts loaders so a hash is always added to the name of output files
This was referenced Aug 6, 2017
Closed
javiereguiluz
added a commit
to symfony/demo
that referenced
this pull request
Sep 27, 2018
…n (bobdenotter)
This PR was merged into the master branch.
Discussion
----------
Updating Yarn dependencies, making build process work again
Some housekeeping on the Yarn / Encore build process:
- Updated `symfony/encore` to `0.20.1` from `0.9.1`
- Update a few other deps
- Build process is now working again
- Changed file naming strategy
Note: I replaced this
```
.enableVersioning(false)
```
with this:
```
.configureFilenames({
js: '[name].js',
images: 'images/[name].[ext]',
fonts: 'fonts/[name].[ext]'
})
```
I did this to keep the delta minimal. Since symfony/webpack-encore#110 `.enableVersioning(false)` is not doing what it says (for understandable reasons), but in this case I chose to keep the filenames without a versioning hash. If you think we should introduce filenames with version hashes instead, i'll happily update this PR.
Commits
-------
44d7267 Updating Yarn dependencies, making build process work again
sayjun0505
added a commit
to sayjun0505/sym_proj
that referenced
this pull request
Apr 16, 2023
…n (bobdenotter)
This PR was merged into the master branch.
Discussion
----------
Updating Yarn dependencies, making build process work again
Some housekeeping on the Yarn / Encore build process:
- Updated `symfony/encore` to `0.20.1` from `0.9.1`
- Update a few other deps
- Build process is now working again
- Changed file naming strategy
Note: I replaced this
```
.enableVersioning(false)
```
with this:
```
.configureFilenames({
js: '[name].js',
images: 'images/[name].[ext]',
fonts: 'fonts/[name].[ext]'
})
```
I did this to keep the delta minimal. Since symfony/webpack-encore#110 `.enableVersioning(false)` is not doing what it says (for understandable reasons), but in this case I chose to keep the filenames without a versioning hash. If you think we should introduce filenames with version hashes instead, i'll happily update this PR.
Commits
-------
44d7267 Updating Yarn dependencies, making build process work again
mwhorse46
added a commit
to mwhorse46/sym_proj
that referenced
this pull request
Apr 16, 2023
…n (bobdenotter)
This PR was merged into the master branch.
Discussion
----------
Updating Yarn dependencies, making build process work again
Some housekeeping on the Yarn / Encore build process:
- Updated `symfony/encore` to `0.20.1` from `0.9.1`
- Update a few other deps
- Build process is now working again
- Changed file naming strategy
Note: I replaced this
```
.enableVersioning(false)
```
with this:
```
.configureFilenames({
js: '[name].js',
images: 'images/[name].[ext]',
fonts: 'fonts/[name].[ext]'
})
```
I did this to keep the delta minimal. Since symfony/webpack-encore#110 `.enableVersioning(false)` is not doing what it says (for understandable reasons), but in this case I chose to keep the filenames without a versioning hash. If you think we should introduce filenames with version hashes instead, i'll happily update this PR.
Commits
-------
44d7267 Updating Yarn dependencies, making build process work again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the configuration of the default assets loaders so a
[hash]is always added to the output file names, even if versioning is disabled.It basically prevents having two files with the same name (but in a different directory) overwriting each other during build.
This closes #73 and was further discussed in #103.