Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match @vue/compiler-sfc requirement with vue #1166

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

dmaicher
Copy link
Contributor

Fixes #1165

@stof
Copy link
Member

stof commented Nov 21, 2022

Why making it a draft PR ?

@dmaicher
Copy link
Contributor Author

Do I need to fix the yarn fails?

@stof
Copy link
Member

stof commented Nov 21, 2022

@Kocal any idea what those failures are about ? To me, it seems like yarn says it fails with errors without actually showing those errors.

@dmaicher
Copy link
Contributor Author

Yeah I cannot fix those.

I tried

yarn set version berry
yarn install

generates a huge yarn.lock diff and still fails

@Kocal
Copy link
Contributor

Kocal commented Nov 21, 2022

Yarn lockfiles from the following testing apps must be updated, since the root package.json has been updated:

as shown in the Yarn's post-resolution validation process:
image

@stof
Copy link
Member

stof commented Nov 21, 2022

ah indeed. I missed that one of those symbols was a GHA group and not the Yarn prefix...

@dmaicher dmaicher marked this pull request as ready for review November 21, 2022 10:32
@weaverryan
Copy link
Member

Thanks @dmaicher and everyone else!

@weaverryan weaverryan merged commit 6fd73c5 into symfony:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency issues with Vue 2.7
4 participants