Add Encore.configureFilenames() method to the public API #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
force-pushed
the
add-configure-filenames
branch
from
bacac22
to
0c9a8fe
Compare
weaverryan
approved these changes
Aug 16, 2017
| * }); | ||
| * | ||
| * Only the filenames defined in the first parameter | ||
| * of this method will be modified. |
There was a problem hiding this comment.
How about:
It's safe to omit a key (e.g. css): the default naming strategy
will be used for those file types.
| * If you are using Encore.enableVersioning() | ||
| * make sure that your "js" filenames contain | ||
| * "[chunkhash]" and your "css" filenames contain | ||
| * "[contenthash]". |
| if (validKeys.indexOf(key) === -1) { | ||
| throw new Error(`"${key}" is not a valid key for configureFilenames(). Valid keys: ${validKeys.join(', ')}.`); | ||
| } | ||
| } |
|
Thank you @Lyrkan! |
weaverryan
added a commit
that referenced
this pull request
Aug 16, 2017
… (Lyrkan) This PR was merged into the master branch. Discussion ---------- Add Encore.configureFilenames() method to the public API This PR adds the `Encore.configureFilenames()` method to the public API (fixes #125). **Example:** ```js Encore.configureFilenames({ js: '[name].[chunkhash].js', css: '[name].[contenthash].css', images: 'images/[name].[hash:8].[ext]', fonts: 'fonts/[name].[hash:8].[ext]' }); ``` If one key is defined in the first parameter it will be used for the filenames of the related category. If it isn't the behavior will stay the same as before. For now I kept the old naming strategies as the default values. We could eventually change that following the discussion in #136. Commits ------- 0c9a8fe Add Encore.configureFilenames() method to the public API
|
Thank you for your time and the feature @Lyrkan @weaverryan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Encore.configureFilenames()method to the public API (fixes #125).Example:
If one key is defined in the first parameter it will be used for the filenames of the related category.
If it isn't the behavior will stay the same as before.
For now I kept the old naming strategies as the default values. We could eventually change that following the discussion in #136.