Intercept Webpack output during functional tests #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fact that stderr messages are still displayed is fine to me. Usages of deprecated APIs should still be reported in our CI (even though it is not our fault this time) |
stof
approved these changes
Aug 18, 2017
|
Awesome! Thank you @Lyrkan! Sorry for the delay - August is almost completely travel... with my infant. Will be back in a week for more complex stuff. I very much appreciate the attention for Encore :) |
weaverryan
added a commit
that referenced
this pull request
Sep 2, 2017
This PR was merged into the master branch. Discussion ---------- Intercept Webpack output during functional tests This PR replaces `process.stdout.write` by an empty function when running webpack in each functional test (fixes #47). It also sets the `silent` option of the Zombie.js browser to true to avoid displaying things like: ``` Download the Vue Devtools extension for a better development experience: https://github.com/vuejs/vue-devtools You are running Vue in development mode. Make sure to turn on production mode when deploying for production. See more tips at https://vuejs.org/guide/deployment.html ``` The only "noisy" message left should be `DeprecationWarning: Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule instead` since it is sent to stderr (should be fixed when alexindigo/webpack-chunk-hash#9 is released). Commits ------- a74869b Intercept output during functional tests (fixes #47)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
process.stdout.writeby an empty function when running webpack in each functional test (fixes #47).It also sets the
silentoption of the Zombie.js browser to true to avoid displaying things like:The only "noisy" message left should be
DeprecationWarning: Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule insteadsince it is sent to stderr (should be fixed when alexindigo/webpack-chunk-hash#9 is released).