Fix "__esModule is not a recognized property" error #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack.config.babel.js file (symfony#166)
Lyrkan
force-pushed
the
fix-babel-webpack-config
branch
from
e1f4d01
to
78ac47a
Compare
weaverryan
reviewed
Sep 25, 2017
|
|
||
| done(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Could this test be inside functional.js instead? Or is there a reason to have it here?
There was a problem hiding this comment.
The issue comes from the way the index.js file is imported in webpack.config.babel.js, and tests in functional.js skip that step by directly creating an instance of WebpackConfig.
I guess we could move the whole test case in functional.js but it would still be some kind of smoke test.
There was a problem hiding this comment.
Nah, works for me here - I just wanted to make sure there was some reason. It's most important for me that it's tested :)
weaverryan
approved these changes
Sep 25, 2017
|
Thanks for the great and fast fix! |
weaverryan
added a commit
that referenced
this pull request
Sep 25, 2017
This PR was merged into the master branch. Discussion ---------- Fix "__esModule is not a recognized property" error This PR removes the "__esModule is not a recognized property" error that is currently displayed after importing Encore using an ES6 import through a `webpack.config.babel.js` file (fixes #166). Commits ------- 78ac47a Fix "__esModule is not a recognized property" error when using a webpack.config.babel.js file (#166)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the "__esModule is not a recognized property" error that is currently displayed after importing Encore using an ES6 import through a
webpack.config.babel.jsfile (fixes #166).