Fix new ts-loader rule being added when getWebpackConfig is called #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, nice catch. Thanks @Lyrkan! |
weaverryan
added a commit
that referenced
this pull request
Oct 14, 2017
…called (Lyrkan) This PR was merged into the master branch. Discussion ---------- Fix new ts-loader rule being added when getWebpackConfig is called Due to the following lines a new ts-loader rule is currently being added everytime the Webpack config is generated (for instance by calling `Encore.getWebpackConfig()`): https://github.com/symfony/webpack-encore/blob/c6057af7521594d9d76cfd072b1f2421591e4a3f/lib/config-generator.js#L196-L200 __Example:__ ```js // webpack.config.js const Encore = require('@symfony/webpack-encore'); Encore .setOutputPath('build') .setPublicPath('/') .addEntry('src/index.ts') .enableTypeScriptLoader() ; console.log(Encore.getWebpackConfig().module.rules.length); // => 5 console.log(Encore.getWebpackConfig().module.rules.length); // => 6 console.log(Encore.getWebpackConfig().module.rules.length); // => 7 ``` Commits ------- a2515b4 Fix ts-loader being added everytime getWebpackConfig is called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the following lines a new ts-loader rule is currently being added everytime the Webpack config is generated (for instance by calling
Encore.getWebpackConfig()):webpack-encore/lib/config-generator.js
Lines 196 to 200 in c6057af
Example: